Skip to content

ENH: add more inputs to AFNI 3dAllineate interface #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2017

Conversation

salma1601
Copy link
Contributor

@salma1601 salma1601 commented Aug 13, 2017

Changes proposed in this pull request

  • add maxrot, maxshf, maxscl and maxshr parameters
  • fix two_blur bug

@codecov-io
Copy link

codecov-io commented Aug 15, 2017

Codecov Report

Merging #2149 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2149      +/-   ##
==========================================
- Coverage   72.25%   72.19%   -0.07%     
==========================================
  Files        1168     1158      -10     
  Lines       58405    58024     -381     
  Branches     8400     8334      -66     
==========================================
- Hits        42201    41888     -313     
+ Misses      14870    14814      -56     
+ Partials     1334     1322      -12
Flag Coverage Δ
#smoketests 72.19% <100%> (-0.07%) ⬇️
#unittests 69.83% <100%> (-0.09%) ⬇️
Impacted Files Coverage Δ
...ipype/interfaces/afni/tests/test_auto_Allineate.py 85.71% <ø> (ø) ⬆️
nipype/interfaces/afni/preprocess.py 83.81% <100%> (+2.43%) ⬆️
nipype/interfaces/freesurfer/longitudinal.py 84.37% <0%> (-8.87%) ⬇️
nipype/interfaces/afni/base.py 51.75% <0%> (-2.65%) ⬇️
nipype/interfaces/afni/utils.py 81.81% <0%> (-1.34%) ⬇️
nipype/interfaces/freesurfer/utils.py 63.19% <0%> (-0.28%) ⬇️
nipype/interfaces/base.py 83.25% <0%> (-0.05%) ⬇️
nipype/interfaces/afni/tests/test_auto_Volreg.py 85.71% <0%> (ø) ⬆️
nipype/interfaces/afni/tests/test_auto_Calc.py 85.71% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e724c...25e9b57. Read the comment docs.

@satra
Copy link
Member

satra commented Aug 17, 2017

@rmarkello @Shotgunosine - seems multiple people are interested in seeing this interface improve. perhaps you all can coordinate across the various efforts.

@salma1601
Copy link
Contributor Author

@rmarkello @Shotgunosine - seems multiple people are interested in seeing this interface improve. perhaps you all can coordinate across the various efforts.

Ok but I don't know how to proceed. May be my changes can be integrated in the ongoing PR #2149 ?

@satra satra merged commit 28df616 into nipy:master Sep 11, 2017
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants